Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed bannerView to a lazy getter to avoid crash when AdBannerController is initialised before window has loaded #1

Merged
merged 1 commit into from Apr 2, 2012

Conversation

nicklockwood
Copy link
Contributor

No description provided.

…oller is initialised before window has loaded

Fixed a couple of typos
@pjcook
Copy link
Owner

pjcook commented Apr 2, 2012

Hi Nick,

Thanks for the update. What are you still doing up though?

Regards

Pj

Sent from my iPad

On 2 Apr 2012, at 00:50, Nick Lockwoodreply@reply.github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/nicklockwood/iAdPlusAdMob master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Changed bannerView to a lazy getter to avoid crash when AdBannerController is initialised before window has loaded

-- File Changes --

M README.txt (2)
M iAdPlusAdMob/AdBannerController.h (4)
M iAdPlusAdMob/AdBannerController.m (73)

-- Patch Links --

https://github.com/pjcook/iAdPlusAdMob/pull/1.patch
https://github.com/pjcook/iAdPlusAdMob/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

@nicklockwood
Copy link
Contributor Author

I don't have to be up early tomorrow so I thought I'd try integrating iAds into Rainbow Blocks. Really impressed with your library so far - it's made the whole process a breeze.

Nick

On 2 Apr 2012, at 01:37, pjcook wrote:

Hi Nick,

Thanks for the update. What are you still doing up though? I can't believe that I'm still making changes to this app though. I've already fallen asleep several times waiting for assets now lol. Hopefully just uploading last version for review.

Regards

Pj

Sent from my iPad

On 2 Apr 2012, at 00:50, Nick Lockwoodreply@reply.github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/nicklockwood/iAdPlusAdMob master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Changed bannerView to a lazy getter to avoid crash when AdBannerController is initialised before window has loaded

-- File Changes --

M README.txt (2)
M iAdPlusAdMob/AdBannerController.h (4)
M iAdPlusAdMob/AdBannerController.m (73)

-- Patch Links --

https://github.com/pjcook/iAdPlusAdMob/pull/1.patch
https://github.com/pjcook/iAdPlusAdMob/pull/1.diff


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:
#1 (comment)

pjcook added a commit that referenced this pull request Apr 2, 2012
Changed bannerView to a lazy getter to avoid crash when AdBannerController is initialised before window has loaded
@pjcook pjcook merged commit ef4a7bb into pjcook:master Apr 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants